package keeper_test import ( "testing" "time" abci "git.cw.tr/mukan-network/mukan-consensus/abci/types" cmtproto "git.cw.tr/mukan-network/mukan-consensus/proto/tendermint/types" "github.com/stretchr/testify/require" "go.uber.org/mock/gomock" "cosmossdk.io/math" storetypes "cosmossdk.io/store/types" "git.cw.tr/mukan-network/mukan-sdk/codec/address" "git.cw.tr/mukan-network/mukan-sdk/runtime" "git.cw.tr/mukan-network/mukan-sdk/testutil" sdk "git.cw.tr/mukan-network/mukan-sdk/types" moduletestutil "git.cw.tr/mukan-network/mukan-sdk/types/module/testutil" authtypes "git.cw.tr/mukan-network/mukan-sdk/x/auth/types" "git.cw.tr/mukan-network/mukan-sdk/x/distribution" "git.cw.tr/mukan-network/mukan-sdk/x/distribution/keeper" distrtestutil "git.cw.tr/mukan-network/mukan-sdk/x/distribution/testutil" disttypes "git.cw.tr/mukan-network/mukan-sdk/x/distribution/types" stakingtypes "git.cw.tr/mukan-network/mukan-sdk/x/staking/types" ) func TestAllocateTokensToValidatorWithCommission(t *testing.T) { ctrl := gomock.NewController(t) key := storetypes.NewKVStoreKey(disttypes.StoreKey) storeService := runtime.NewKVStoreService(key) testCtx := testutil.DefaultContextWithDB(t, key, storetypes.NewTransientStoreKey("transient_test")) encCfg := moduletestutil.MakeTestEncodingConfig(distribution.AppModuleBasic{}) ctx := testCtx.Ctx.WithBlockHeader(cmtproto.Header{Time: time.Now()}) bankKeeper := distrtestutil.NewMockBankKeeper(ctrl) stakingKeeper := distrtestutil.NewMockStakingKeeper(ctrl) accountKeeper := distrtestutil.NewMockAccountKeeper(ctrl) valCodec := address.NewBech32Codec("cosmosvaloper") accountKeeper.EXPECT().GetModuleAddress("distribution").Return(distrAcc.GetAddress()) stakingKeeper.EXPECT().ValidatorAddressCodec().Return(valCodec).AnyTimes() distrKeeper := keeper.NewKeeper( encCfg.Codec, storeService, accountKeeper, bankKeeper, stakingKeeper, "fee_collector", authtypes.NewModuleAddress("gov").String(), ) // create validator with 50% commission val, err := distrtestutil.CreateValidator(valConsPk0, math.NewInt(100)) require.NoError(t, err) val.Commission = stakingtypes.NewCommission(math.LegacyNewDecWithPrec(5, 1), math.LegacyNewDecWithPrec(5, 1), math.LegacyNewDec(0)) stakingKeeper.EXPECT().ValidatorByConsAddr(gomock.Any(), sdk.GetConsAddress(valConsPk0)).Return(val, nil).AnyTimes() // allocate tokens tokens := sdk.DecCoins{ {Denom: sdk.DefaultBondDenom, Amount: math.LegacyNewDec(10)}, } require.NoError(t, distrKeeper.AllocateTokensToValidator(ctx, val, tokens)) // check commission expected := sdk.DecCoins{ {Denom: sdk.DefaultBondDenom, Amount: math.LegacyNewDec(5)}, } valBz, err := valCodec.StringToBytes(val.GetOperator()) require.NoError(t, err) valCommission, err := distrKeeper.GetValidatorAccumulatedCommission(ctx, valBz) require.NoError(t, err) require.Equal(t, expected, valCommission.Commission) // check current rewards currentRewards, err := distrKeeper.GetValidatorCurrentRewards(ctx, valBz) require.NoError(t, err) require.Equal(t, expected, currentRewards.Rewards) } func TestAllocateTokensToManyValidators(t *testing.T) { ctrl := gomock.NewController(t) key := storetypes.NewKVStoreKey(disttypes.StoreKey) storeService := runtime.NewKVStoreService(key) testCtx := testutil.DefaultContextWithDB(t, key, storetypes.NewTransientStoreKey("transient_test")) encCfg := moduletestutil.MakeTestEncodingConfig(distribution.AppModuleBasic{}) ctx := testCtx.Ctx.WithBlockHeader(cmtproto.Header{Time: time.Now()}) bankKeeper := distrtestutil.NewMockBankKeeper(ctrl) stakingKeeper := distrtestutil.NewMockStakingKeeper(ctrl) accountKeeper := distrtestutil.NewMockAccountKeeper(ctrl) feeCollectorAcc := authtypes.NewEmptyModuleAccount("fee_collector") accountKeeper.EXPECT().GetModuleAddress("distribution").Return(distrAcc.GetAddress()) accountKeeper.EXPECT().GetModuleAccount(gomock.Any(), "fee_collector").Return(feeCollectorAcc) stakingKeeper.EXPECT().ValidatorAddressCodec().Return(address.NewBech32Codec("cosmosvaloper")).AnyTimes() distrKeeper := keeper.NewKeeper( encCfg.Codec, storeService, accountKeeper, bankKeeper, stakingKeeper, "fee_collector", authtypes.NewModuleAddress("gov").String(), ) // reset fee pool & set params require.NoError(t, distrKeeper.Params.Set(ctx, disttypes.DefaultParams())) require.NoError(t, distrKeeper.FeePool.Set(ctx, disttypes.InitialFeePool())) // create validator with 50% commission valAddr0 := sdk.ValAddress(valConsAddr0) val0, err := distrtestutil.CreateValidator(valConsPk0, math.NewInt(100)) require.NoError(t, err) val0.Commission = stakingtypes.NewCommission(math.LegacyNewDecWithPrec(5, 1), math.LegacyNewDecWithPrec(5, 1), math.LegacyNewDec(0)) stakingKeeper.EXPECT().ValidatorByConsAddr(gomock.Any(), sdk.GetConsAddress(valConsPk0)).Return(val0, nil).AnyTimes() // create second validator with 0% commission valAddr1 := sdk.ValAddress(valConsAddr1) val1, err := distrtestutil.CreateValidator(valConsPk1, math.NewInt(100)) require.NoError(t, err) val1.Commission = stakingtypes.NewCommission(math.LegacyNewDec(0), math.LegacyNewDec(0), math.LegacyNewDec(0)) stakingKeeper.EXPECT().ValidatorByConsAddr(gomock.Any(), sdk.GetConsAddress(valConsPk1)).Return(val1, nil).AnyTimes() abciValA := abci.Validator{ Address: valConsPk0.Address(), Power: 100, } abciValB := abci.Validator{ Address: valConsPk1.Address(), Power: 100, } // assert initial state: zero outstanding rewards, zero community pool, zero commission, zero current rewards val0OutstandingRewards, err := distrKeeper.GetValidatorOutstandingRewards(ctx, valAddr0) require.NoError(t, err) require.True(t, val0OutstandingRewards.Rewards.IsZero()) val1OutstandingRewards, err := distrKeeper.GetValidatorOutstandingRewards(ctx, valAddr1) require.NoError(t, err) require.True(t, val1OutstandingRewards.Rewards.IsZero()) feePool, err := distrKeeper.FeePool.Get(ctx) require.NoError(t, err) require.True(t, feePool.CommunityPool.IsZero()) val0Commission, err := distrKeeper.GetValidatorAccumulatedCommission(ctx, valAddr0) require.NoError(t, err) require.True(t, val0Commission.Commission.IsZero()) val1Commission, err := distrKeeper.GetValidatorAccumulatedCommission(ctx, valAddr1) require.NoError(t, err) require.True(t, val1Commission.Commission.IsZero()) val0CurrentRewards, err := distrKeeper.GetValidatorCurrentRewards(ctx, valAddr0) require.NoError(t, err) require.True(t, val0CurrentRewards.Rewards.IsZero()) val1CurrentRewards, err := distrKeeper.GetValidatorCurrentRewards(ctx, valAddr1) require.NoError(t, err) require.True(t, val1CurrentRewards.Rewards.IsZero()) // allocate tokens as if both had voted and second was proposer fees := sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, math.NewInt(100))) bankKeeper.EXPECT().GetAllBalances(gomock.Any(), feeCollectorAcc.GetAddress()).Return(fees) bankKeeper.EXPECT().SendCoinsFromModuleToModule(gomock.Any(), "fee_collector", disttypes.ModuleName, fees) votes := []abci.VoteInfo{ { Validator: abciValA, }, { Validator: abciValB, }, } require.NoError(t, distrKeeper.AllocateTokens(ctx, 200, votes)) // 98 outstanding rewards (100 less 2 to community pool) val0OutstandingRewards, err = distrKeeper.GetValidatorOutstandingRewards(ctx, valAddr0) require.NoError(t, err) require.Equal(t, sdk.DecCoins{{Denom: sdk.DefaultBondDenom, Amount: math.LegacyNewDecWithPrec(490, 1)}}, val0OutstandingRewards.Rewards) val1OutstandingRewards, err = distrKeeper.GetValidatorOutstandingRewards(ctx, valAddr1) require.NoError(t, err) require.Equal(t, sdk.DecCoins{{Denom: sdk.DefaultBondDenom, Amount: math.LegacyNewDecWithPrec(490, 1)}}, val1OutstandingRewards.Rewards) // 2 community pool coins feePool, err = distrKeeper.FeePool.Get(ctx) require.NoError(t, err) require.Equal(t, sdk.DecCoins{{Denom: sdk.DefaultBondDenom, Amount: math.LegacyNewDec(2)}}, feePool.CommunityPool) // 50% commission for first proposer, (0.5 * 98%) * 100 / 2 = 23.25 val0Commission, err = distrKeeper.GetValidatorAccumulatedCommission(ctx, valAddr0) require.NoError(t, err) require.Equal(t, sdk.DecCoins{{Denom: sdk.DefaultBondDenom, Amount: math.LegacyNewDecWithPrec(2450, 2)}}, val0Commission.Commission) // zero commission for second proposer val1Commission, err = distrKeeper.GetValidatorAccumulatedCommission(ctx, valAddr1) require.NoError(t, err) require.True(t, val1Commission.Commission.IsZero()) // just staking.proportional for first proposer less commission = (0.5 * 98%) * 100 / 2 = 24.50 val0CurrentRewards, err = distrKeeper.GetValidatorCurrentRewards(ctx, valAddr0) require.NoError(t, err) require.Equal(t, sdk.DecCoins{{Denom: sdk.DefaultBondDenom, Amount: math.LegacyNewDecWithPrec(2450, 2)}}, val0CurrentRewards.Rewards) // proposer reward + staking.proportional for second proposer = (0.5 * (98%)) * 100 = 49 val1CurrentRewards, err = distrKeeper.GetValidatorCurrentRewards(ctx, valAddr1) require.NoError(t, err) require.Equal(t, sdk.DecCoins{{Denom: sdk.DefaultBondDenom, Amount: math.LegacyNewDecWithPrec(490, 1)}}, val1CurrentRewards.Rewards) } func TestAllocateTokensTruncation(t *testing.T) { ctrl := gomock.NewController(t) key := storetypes.NewKVStoreKey(disttypes.StoreKey) storeService := runtime.NewKVStoreService(key) testCtx := testutil.DefaultContextWithDB(t, key, storetypes.NewTransientStoreKey("transient_test")) encCfg := moduletestutil.MakeTestEncodingConfig(distribution.AppModuleBasic{}) ctx := testCtx.Ctx.WithBlockHeader(cmtproto.Header{Time: time.Now()}) bankKeeper := distrtestutil.NewMockBankKeeper(ctrl) stakingKeeper := distrtestutil.NewMockStakingKeeper(ctrl) accountKeeper := distrtestutil.NewMockAccountKeeper(ctrl) feeCollectorAcc := authtypes.NewEmptyModuleAccount("fee_collector") accountKeeper.EXPECT().GetModuleAddress("distribution").Return(distrAcc.GetAddress()) accountKeeper.EXPECT().GetModuleAccount(gomock.Any(), "fee_collector").Return(feeCollectorAcc) stakingKeeper.EXPECT().ValidatorAddressCodec().Return(address.NewBech32Codec("cosmosvaloper")).AnyTimes() distrKeeper := keeper.NewKeeper( encCfg.Codec, storeService, accountKeeper, bankKeeper, stakingKeeper, "fee_collector", authtypes.NewModuleAddress("gov").String(), ) // reset fee pool require.NoError(t, distrKeeper.FeePool.Set(ctx, disttypes.InitialFeePool())) require.NoError(t, distrKeeper.Params.Set(ctx, disttypes.DefaultParams())) // create validator with 10% commission valAddr0 := sdk.ValAddress(valConsAddr0) val0, err := distrtestutil.CreateValidator(valConsPk0, math.NewInt(100)) require.NoError(t, err) val0.Commission = stakingtypes.NewCommission(math.LegacyNewDecWithPrec(1, 1), math.LegacyNewDecWithPrec(1, 1), math.LegacyNewDec(0)) stakingKeeper.EXPECT().ValidatorByConsAddr(gomock.Any(), sdk.GetConsAddress(valConsPk0)).Return(val0, nil).AnyTimes() // create second validator with 10% commission valAddr1 := sdk.ValAddress(valConsAddr1) val1, err := distrtestutil.CreateValidator(valConsPk1, math.NewInt(100)) require.NoError(t, err) val1.Commission = stakingtypes.NewCommission(math.LegacyNewDecWithPrec(1, 1), math.LegacyNewDecWithPrec(1, 1), math.LegacyNewDec(0)) stakingKeeper.EXPECT().ValidatorByConsAddr(gomock.Any(), sdk.GetConsAddress(valConsPk1)).Return(val1, nil).AnyTimes() // create third validator with 10% commission valAddr2 := sdk.ValAddress(valConsAddr2) val2, err := stakingtypes.NewValidator(sdk.ValAddress(valConsAddr2).String(), valConsPk1, stakingtypes.Description{}) require.NoError(t, err) val2.Commission = stakingtypes.NewCommission(math.LegacyNewDecWithPrec(1, 1), math.LegacyNewDecWithPrec(1, 1), math.LegacyNewDec(0)) stakingKeeper.EXPECT().ValidatorByConsAddr(gomock.Any(), sdk.GetConsAddress(valConsPk2)).Return(val2, nil).AnyTimes() abciValA := abci.Validator{ Address: valConsPk0.Address(), Power: 11, } abciValB := abci.Validator{ Address: valConsPk1.Address(), Power: 10, } abciValC := abci.Validator{ Address: valConsPk2.Address(), Power: 10, } // assert initial state: zero outstanding rewards, zero community pool, zero commission, zero current rewards val0OutstandingRewards, err := distrKeeper.GetValidatorOutstandingRewards(ctx, valAddr0) require.NoError(t, err) require.True(t, val0OutstandingRewards.Rewards.IsZero()) val1OutstandingRewards, err := distrKeeper.GetValidatorOutstandingRewards(ctx, valAddr1) require.NoError(t, err) require.True(t, val1OutstandingRewards.Rewards.IsZero()) feePool, err := distrKeeper.FeePool.Get(ctx) require.NoError(t, err) require.True(t, feePool.CommunityPool.IsZero()) val0Commission, err := distrKeeper.GetValidatorAccumulatedCommission(ctx, valAddr0) require.NoError(t, err) require.True(t, val0Commission.Commission.IsZero()) val1Commission, err := distrKeeper.GetValidatorAccumulatedCommission(ctx, valAddr1) require.NoError(t, err) require.True(t, val1Commission.Commission.IsZero()) val0CurrentRewards, err := distrKeeper.GetValidatorCurrentRewards(ctx, valAddr0) require.NoError(t, err) require.True(t, val0CurrentRewards.Rewards.IsZero()) val1CurrentRewards, err := distrKeeper.GetValidatorCurrentRewards(ctx, valAddr1) require.NoError(t, err) require.True(t, val1CurrentRewards.Rewards.IsZero()) // allocate tokens as if both had voted and second was proposer fees := sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, math.NewInt(634195840))) bankKeeper.EXPECT().GetAllBalances(gomock.Any(), feeCollectorAcc.GetAddress()).Return(fees) bankKeeper.EXPECT().SendCoinsFromModuleToModule(gomock.Any(), "fee_collector", disttypes.ModuleName, fees) votes := []abci.VoteInfo{ { Validator: abciValA, }, { Validator: abciValB, }, { Validator: abciValC, }, } require.NoError(t, distrKeeper.AllocateTokens(ctx, 31, votes)) val0OutstandingRewards, err = distrKeeper.GetValidatorOutstandingRewards(ctx, valAddr0) require.NoError(t, err) require.True(t, val0OutstandingRewards.Rewards.IsValid()) val1OutstandingRewards, err = distrKeeper.GetValidatorOutstandingRewards(ctx, valAddr1) require.NoError(t, err) require.True(t, val1OutstandingRewards.Rewards.IsValid()) val2OutstandingRewards, err := distrKeeper.GetValidatorOutstandingRewards(ctx, valAddr2) require.NoError(t, err) require.True(t, val2OutstandingRewards.Rewards.IsValid()) }